IS-1900: Aksel DS in dialogmøte-referat-deltakere components #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersrognstad
changed the title
Comment on lines
+54
to
55
| <div className="mt-4"> | ||
| <FieldArray<NewDialogmotedeltakerAnnenDTO> name={"andreDeltakere"}> |
There was a problem hiding this comment.
Kan stylingen bare ligge på FieldArray eller blir det krøll da? 🤔
There was a problem hiding this comment.
Funket ikke 😞 FieldArray kommer vel fra form-biblioteket og ser ikke ut til å ha className-prop.
| <FlexRow topPadding={PaddingSize.SM}> | ||
| <Normaltekst>{texts.behandlerTekst}</Normaltekst> | ||
| </FlexRow> | ||
| <FlexRow topPadding={PaddingSize.SM}>{texts.behandlerTekst}</FlexRow> |
There was a problem hiding this comment.
Trenger ikke å gjøre det i denne PR'en, men er FlexRow noe vi egentlig vil fase ut? Jeg synes at en slik komponent hadde vært enklere å lese om den bare stod i klartekst med tailwind classes😊
There was a problem hiding this comment.
Ja, litt enig i det. Har erstattet det noen steder, men ble litt mye i denne PRen så lot det ligge enn så lenge.
vetlesolgaard
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hva har blitt lagt til✨🌈
Endret til å bruke Aksel DS + mer tailwind i Referat-deltakere-komponenter.
Screenshots 📸✨