Skip to content

Conversation

@time-by-waves
Copy link

No description provided.

…owerShell files to modernize the batch scripts, included some tests, added release workflow
…m-uri

Run a Security Audit with ChatGPT 4.5
Copilot AI review requested due to automatic review settings July 5, 2025 00:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds automated build pipelines for plugin releases, updates project targets to .NET Framework 4.8, and introduces URL credential‐stripping logic with accompanying tests.

  • Introduce PowerShell build scripts (plgx-build.ps1, plgx-build-install-run-loop.ps1) and a GitHub Actions workflow for release packaging.
  • Update both main and test projects to target .NET Framework 4.8.
  • Add StripUserInfo in FaviconDownloader, logging, and unit tests for credential stripping.

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
plgx-build.ps1 New PS script for cleaning, building, packaging, and deploying plugin
plgx-build-install-run-loop.ps1 Loop script to rebuild, install, and run KeePass on exit
YAFD/YetAnotherFaviconDownloader.csproj Target framework bumped from v4.5 to v4.8
YAFD/Util.cs Add file-based debug logging
YAFD/FaviconDownloader.cs Add StripUserInfo helper and invoke it in URL validation
Tests/Tests.csproj Updated to .NET 4.8; add test for IsValidURL
Tests/IsValidURLTest.cs New tests covering user‐info stripping
SECURITYAUDIT.md Detailed security audit documentation
BUILD.md New build and run guide
.github/workflows/build-and-release.yml CI workflow for build and release
Files not reviewed (1)
  • YAFD/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (4)

BUILD.md:6

  • Update this prerequisite to .NET Framework 4.8 targeting pack to match the project’s updated target framework.
* .NET Framework 4.5 targeting pack (VS installs it)

BUILD.md:53

  • [nitpick] This instruction is duplicated later in the file (around line 108); consider removing the redundant block to clean up the documentation.
Include the output of `msbuild -version` and `KeePass.exe --version` when opening build‐related issues.

Tests/IsValidURLTest.cs:28

  • Add additional test cases for URLs without a schema when automatic prefixing is enabled and disabled, to verify the prefix logic in IsValidURL.
        [DataTestMethod]

.github/workflows/build-and-release.yml:23

  • Invoke the PowerShell script explicitly using pwsh -NoProfile -ExecutionPolicy Bypass -File .\plgx-build.ps1 to ensure it executes correctly on the Windows runner.
        run: plgx-build.ps1

@time-by-waves time-by-waves marked this pull request as draft July 5, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant