Skip to content

fix: Add table name whitelist to prevent SQL injection in project del… #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prabinoid merged 1 commit into from
Apr 13, 2026
+6 −1
Merged

fix: Add table name whitelist to prevent SQL injection in project del… #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion backend/models/postgis/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,10 +926,15 @@ async def delete(self, db: Database):
"project_partnerships",
]

# Whitelist of allowed table names to prevent SQL injection via
# dynamic table name interpolation, since table names cannot be parameterized.
allowed_tables = set(related_tables)

# Start a transaction to ensure atomic deletion
async with db.transaction():
# Loop through each table and execute the delete query
for table in related_tables:
if table not in allowed_tables:
raise ValueError(f"Invalid table name: {table}")
await db.execute(
f"DELETE FROM {table} WHERE project_id = :project_id",
{"project_id": self.id},
Expand Down
Loading