Renaming the cities of Ukraine #12
Open
rublin wants to merge 3 commits into
Open
Conversation
|
I believe this is not a correct place for this, the script uses Edit: I also believe this change is never going to happen, as this would break all existing users, as programs depend on names. |
|
No, the list of names is hard-coded in |
|
Instead of hard-coding the list of timezones, one could just do: import os
import glob
import natsort
ZONES_DIR = "/usr/share/zoneinfo/"
def zone_info_filter(zones):
return [f for f in zones if (
os.path.isfile(ZONES_DIR + f) and
not os.path.islink(ZONES_DIR + f) and
not f.startswith("right")
)]
ZONES = glob.glob("*/**", root_dir=ZONES_DIR, recursive=True)
ZONES = zone_info_filter(ZONES)
# Sort naturally
ZONES = natsort.realsorted(ZONES)
# Move Etc down
ZONES.sort(key=lambda x: x.startswith("Etc/"))You'll notice that:
It basically means that the timezone files included in this repository are rather outdated |
|
@nayarsystems what do you think? Here's the relevant PR: #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI: https://en.wikipedia.org/wiki/KyivNotKiev