NAY4-3 Update _isSelfOnboardingApproved to take role as a bytes32 instead of string

[Huanzhang89]

Only the check _isSelfOnboardingApproved is updated to use bytes32 for the _role parameter, other functions such as _approveSelfOnboarding still take string.

[amarinkovic]

We should stick with the existing naming convention, no need for Bytes32 in variable names. It is part of the overall design, all IDs are of type bytes32 across the codebase. Naming it roleId is how it's done everywhere else, so it would keep things consistent.

[Huanzhang89]

We should stick with the existing naming convention, no need for Bytes32 in variable names. It is part of the overall design, all IDs are of type bytes32 across the codebase. Naming it roleId is how it's done everywhere else, so it would keep things consistent.

Got it, I've made the change

[amarinkovic]

Both _isSelfOnboardingApproved and _approveSelfOnboarding should be changed to accept the bytes32 roleId, together with the corresponding method in the facet. Original report was about the _isSelfOnboardingApproved only, but we should keep things consistent across the board.

[Huanzhang89]

made the updates and the tests are all fixed aswell

[amarinkovic]

Thank you!