Skip to content

MinGW Support + CMake Refactor#149

Merged
BrentDaMage merged 7 commits intonbcraft-org:masterfrom
TheBrokenRail:cmake-v3
May 1, 2025
Merged

MinGW Support + CMake Refactor#149
BrentDaMage merged 7 commits intonbcraft-org:masterfrom
TheBrokenRail:cmake-v3

Conversation

@TheBrokenRail
Copy link
Copy Markdown
Contributor

@TheBrokenRail TheBrokenRail commented Apr 20, 2025

This PR:

  • Splits sound backends from platform backends
    • This allows you to easily build Android with OpenSL or OpenAL
    • Or build Windows with OpenAL or DirectSound
  • Adds support for building the CMake project with MinGW-w64
    • This is added to the CI
    • This allows the Windows version to be built on Linux
  • Changes Logger to be initialized in main rather than AppPlatform
    • This fixes some bugs where messages would fail to log after the AppPlatform is destroyed
  • Finally removes the GLES comparability layer
  • Enables OpenGL lighting on all platforms
  • Fixes other miscellaneous bugs

@TheBrokenRail TheBrokenRail mentioned this pull request Apr 20, 2025
Closed
BrentDaMage
BrentDaMage approved these changes May 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@BrentDaMage BrentDaMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread platforms/sdl/base/AppPlatform_sdl_base.cpp
BrentDaMage
BrentDaMage reviewed May 1, 2025
View reviewed changes
Comment thread source/client/renderer/entity/MobRenderer.cpp
@BrentDaMage BrentDaMage merged commit 5ef48b8 into nbcraft-org:master May 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrentDaMage BrentDaMage BrentDaMage approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheBrokenRail @BrentDaMage