Load Sound Data From Files#150
Conversation
* Added support for streaming sounds via SoundStream * Added SoundStream base class and SoundStreamAL * SoundEngine listener position
* Fixed SoundStreamAL buffer re-use * Abstracted private SoundStreamAL functions * Added music to music_list.h * Moved AL_ERROR_CHECK to /thirdparty/OpenAL.h * Added AL_ERROR_SILENCE
|
|
||
| void Mob::baseTick() | ||
| { | ||
| m_oAttackAnim = m_attackAnim; |
There was a problem hiding this comment.
A good chunk of changes to this file seem to solely be indentation changes. These should probably be changed back to tabs, unless the project's code-style is being changed.
There was a problem hiding this comment.
There is no code-styling dictated for spaces vs tabs. There are actually tons of places where they are inconsistently used. I would change this back, but it would take extra effort, and I am lazy.
|
|
||
| while (size < _tempPcmBufferSize) | ||
| { | ||
| result = stb_vorbis_get_samples_short_interleaved(_decoder, _info.channels, _tempPcmBuffer + size, _tempPcmBufferSize - size); |
There was a problem hiding this comment.
Shouldn't OGG decoding be in platform-agnostic code?
There was a problem hiding this comment.
How would you suggest we abstract it out?
There was a problem hiding this comment.
Maybe make an API where the core code can ask for a platform-agnostic buffer object, then upload the decoded data to that?
But putting decoding code in every sound backend (and we have three!) seems like a bad idea.
|
Damn, forgot to push. This should be all good to go imo, I'd just like someone to review it before it's merged upstream. |
|
@TheBrokenRail could you please update the README.md file to reflect the new script you added? |
|
Done! |
2 participants
Fixes #119
This PR:
.pcmor.oggfiles instead of embedding it in the binary.pcmfiles