added support for zapping replaceable events #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitcoinpirate
force-pushed
the
support_replaceable_events
branch
from
e337b1e to
914504d
Compare
|
This code isn't zapping the replaceable event itself, but another replaceable events referenced by the target. To zap the replaceable event you would have to check if the target is replaceable, then build your own |
bitcoinpirate
force-pushed
the
support_replaceable_events
branch
2 times, most recently
from
7ae5831 to
6b35f06
Compare
AsaiToshiya
requested changes
Oct 21, 2024
fiatjaf
force-pushed
the
master
branch
2 times, most recently
from
4d4b83e to
bf0c4d4
Compare
SnowCait
reviewed
Jan 22, 2025
|
If there is no response from @bitcoinpirate, I will edit and merge theirs fork. |
AsaiToshiya
force-pushed
the
support_replaceable_events
branch
from
7eed891 to
0247a89
Compare
|
@SnowCait I applied your good suggestions. |
AsaiToshiya
approved these changes
Feb 23, 2025
|
I will merge today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #291
I tried to keep it backwards compatible by allowing the event id and the event object.