fix: failing tests #432
Merged
fix: failing tests #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NostrTypeGuard was moved to nip19.ts in commit 45b25c5 but tests stayed in core.test.ts and started failing because it still imported NostrTypeGuard from core.ts - which wasn't there.
this way we don't need to repeat NostrTypeGuard in each tests description
|
I think we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
NostrTypeGuardwas moved fromcore.tstonip19.tsin the following commit 45b25c5 the tests were left behind incore.test.tscore.test.tswas still trying to importNostrTypeGuardfromcore.tsand threw this error when running testsChanges
nip19.test.tsdescribeblock forNostrTypeGuard