Typescript type inference for 'decode' function in nip19 is not working fully #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioconselheiro
changed the title
|
Good evening, @antonioconselheiro. |
|
Good morning from here, |
|
Your PRs always make me want to switch to raw JavaScript. |
|
I worked in large systems with raw JavaScript, TypeScript types helped me sleep better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Decode' function is not returning specific type for specific parameters signature.
In this request I'm including alternative specific signatures if the first generic signature fails, this will solve complexity of extra validation after decoding or forcing cast using 'as' keyword.
To validate this implementation I have remove the keyword 'as' for cast into unit tests, so the unit tests validates the returning type also. 'As' keyword will force the return to the type dev wish, but if the parameter change it'll keep returning the forced type and will show no type error.
Currently (one signature, multiple return):
With the changes of this pull request (fixed):
