Skip to content

Conversation

CodyTseng
Copy link
Contributor

  1. When ws.onerror or ws.onclose events are triggered before a successful connection (while this._connected is still false), the this.onclose?.() callback was not being called. This prevented the relay from being removed from the pool, making it impossible to reconnect via ensureRelay.

  2. Potential error in close sequence: The this.onclose?.() callback was called after this.ws?.close(), which could potentially throw an error and prevent the this.onclose?.() callback from executing.

@fiatjaf fiatjaf merged commit 8866042 into nbd-wtf:master Aug 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants