relay: ensure onclose callback is triggered #501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ws.onerror
orws.onclose
events are triggered before a successful connection (whilethis._connected
is stillfalse
), thethis.onclose?.()
callback was not being called. This prevented the relay from being removed from the pool, making it impossible to reconnect viaensureRelay
.Potential error in close sequence: The
this.onclose?.()
callback was called afterthis.ws?.close()
, which could potentially throw an error and prevent thethis.onclose?.()
callback from executing.