Reconnect with exponential backoff flag: enableReconnect
#507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. I think I created some conflicts when I merged that other PR. Can you fix them and then I'll merge (or perhaps squash will be better)? |
|
Fixed, thank you! |
|
I don't have a preference between squash or merge, all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag
enableReconnectwhich turns on an exponential-backoff reconnection sequence for relay subscriptions. When a relay disconnects, reconnection will be attempted with a delay that gets longer with each attempt.If
enableReconnectis set to a callback function it will be called when reconnection occurs and passed the current subscription. This can be used to modify the subscription filters or e.g. thesinceparameter to fetch only newer events. The updated subscription will then be used.This PR also:
enablePingand incorporates Improvements to enablePing() & tests #506 with more of the same.Here's a simple HTML file test: reconnect-test.html.zip (put it in
nostr-toolsand runjust buildand then open it)Fixes #491.