FileConventions(Test),scripts: take .env file into account #205
Conversation
webwarrior-ws
force-pushed
the
github-versions-env
branch
2 times, most recently
from
dd5cb66 to
b713a0b
Compare
|
Let's:
|
|
BTW, typo: Comventions. |
webwarrior-ws
force-pushed
the
github-versions-env
branch
from
b713a0b to
9b0752a
Compare
webwarrior-ws
changed the title
Fixed typo |
I can't really add a test before the changes because the signature of the tested function ( |
That's a poor excuse, changing the signature is ok, but only that change in the non-unittest assembly is allowed. |
webwarrior-ws
force-pushed
the
github-versions-env
branch
2 times, most recently
from
6a3fa8e to
f815f61
Compare
To functions used to detect inconsistent versions in GithubCI. This change is needed to be able to take .env file into account when searching for vars referenced in Github workflow files.
Added test for detecting inconsistent versions in Github workflow files with values in global environment dictionary. Contains failing test.
Take .env file into account in inconsistentVersionsInGitHubCI.fsx script when searching for vars referenced in Github workflow files, when .env file is present in the repository root. This is needed because workflows in pulumi-deploy now load vars from .env file.
webwarrior-ws
force-pushed
the
github-versions-env
branch
from
8fd0f4a to
c5e3890
Compare
|
Added commit that only changes the function's signature, then commit that adds test. And the last one with implementation. |
| @@ -0,0 +1,25 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
@webwarrior-ws given that the tests themselves depend on files present inside this DummyFiles/ folder, then I'd prefer to include the env vars in an .env file inside this same folder. Also, let's rename this file to include "DotEnv" in the name
There was a problem hiding this comment.
The functionality of parsing .env file is only in the .fsx script, not in Library.fs. Also that file is expected to be ../../ relative to target dir (.github/workflows).
2 participants
In inconsistentVersionsInGitHubCI.fsx script when searching for vars referenced in Github workflow files, when .env file is present in the repository root. This is needed because workflows in pulumi-deploy now load vars from .env file.