Skip to content

Frontend.XF.GTK: fix currency colors on GTK#259

Open
Mersho wants to merge 1 commit into
nblockchain:masterfrom
Mersho:FixCoinColorIndicator
Open

Frontend.XF.GTK: fix currency colors on GTK#259
Mersho wants to merge 1 commit into
nblockchain:masterfrom
Mersho:FixCoinColorIndicator

Conversation

@Mersho

@Mersho Mersho commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Fix currency color indicator on GTK which was not showing up. To address this, we double its width when the platform is GTK.

@knocte

knocte commented Mar 1, 2024

Copy link
Copy Markdown
Member

Please compare the scope you used here and the scope you used in PR257, you already forgot our conventions?

Fix currency color indicator on GTK which was not showing up.
To address this, we double its width when the platform is GTK.

Co-authored-by: webwarrior <reg@webwarrior.ws>
@Mersho Mersho force-pushed the FixCoinColorIndicator branch from 7acead9 to 237b7c6 Compare March 4, 2024 08:42
@Mersho Mersho changed the title GWallet.Frontend.XF: fix currency colors on GTK Frontend.XF.GTK: fix currency colors on GTK Mar 4, 2024
@knocte

knocte commented Mar 4, 2024

Copy link
Copy Markdown
Member

Fix currency color indicator on GTK which was not showing up

Actually, I just tested geewallet v0.7.430.0 in Ubuntu 22.04.3 and I see the colours:

Screenshot 2024-03-04 at 11 25 56 PM

So please tell me how did you test this? and what version of ubuntu

@Mersho

Mersho commented Mar 5, 2024

Copy link
Copy Markdown
Contributor Author

So please tell me how did you test this? and what version of ubuntu

I tested geewallet v0.7.431.0 in ubuntu 22.04 LTS by installing the CI-uploaded snap artifact from the master branch.

@knocte

knocte commented Mar 5, 2024

Copy link
Copy Markdown
Member

Show me a screenshot of that.

@Mersho

Mersho commented Mar 5, 2024

Copy link
Copy Markdown
Contributor Author

I also tested the v0.7.430.0 right now:

image

@knocte

knocte commented Mar 5, 2024

Copy link
Copy Markdown
Member

I dont understand that screenshot, do you have 1 LTC, 1 ETH, 1 ETC....? The configuration flag that changes balances like that can only be used when compiling your own version of snap, so I AM SURE YOU ARE NOT TESTING 0.7.430.0!!!!

@Mersho

Mersho commented Mar 5, 2024

Copy link
Copy Markdown
Contributor Author

Here is the another screenshot of geewallet 0.7.430.0 downloaded from nblockchain/geewallet:

image

@knocte

knocte commented Mar 5, 2024

Copy link
Copy Markdown
Member

I dont reproduce that bug. Please download Ubuntu 22.04.3 while you're working on other things.

@Mersho

Mersho commented Mar 5, 2024

Copy link
Copy Markdown
Contributor Author

I dont reproduce that bug. Please download Ubuntu 22.04.3 while you're working on other things.

results is same on Ubuntu 22.04.3:

image

@knocte knocte force-pushed the master branch 2 times, most recently from b841302 to ccb1641 Compare May 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants