Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for global ids inside of list #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GlassySundew
Copy link

fixed a bug in getSheetLines() if you referenced an in-list type from inside a custom type: Reflect.field could retrieve column data instead of an array
filled macro model data.sheets with actual data of in-list types
filled runtime model root.sheets with actual data of in-list types

@ncannasse
Copy link
Owner

I think that is not correct. You shouldn't set sheet lines as most of subsheets have empty lines data because their actual data is split into several objects and we don't want data duplication here.

@GlassySundew
Copy link
Author

GlassySundew commented Feb 16, 2025

Thank you for your response.
Pardon my ignorance, but macro code is hard for me to comprehend and I cannot find mentioned "split" subsheet data anywhere, I tried to create a reference to a subsheet that has a unique id with global scope and I only see string id in the debugger at the place.
If you write a custom type that references a subsheet, compilation will output an error (without the fix)

enum NpcResponseActionType {
    SetChain( response : npcResponse@responses );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants