Skip to content

Fix game crash from localization - #47

Open
Galandrielle wants to merge 31 commits into
ncase:masterfrom
Galandrielle:Fix-game-crash-from-localization
Open

Fix game crash from localization#47
Galandrielle wants to merge 31 commits into
ncase:masterfrom
Galandrielle:Fix-game-crash-from-localization

Conversation

@Galandrielle

@Galandrielle Galandrielle commented Jun 21, 2022

Copy link
Copy Markdown

The game is crashing with this error:

Error: Scene_Preloader.js:49 Uncaught ReferenceError: textStrings is not defined

This pull request will fix the game crash in localization so that the Greek translation can be added.

@Galandrielle Galandrielle mentioned this pull request Jun 21, 2022
@Galandrielle Galandrielle reopened this Jun 21, 2022

@natan-dias natan-dias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.

Comment thread js/textStrings.js

var textStrings = textStrings_FA
//var textStrings = textStrings_KR;
const textStrings = (() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code. I will add that to my fork, while we don't have this PR approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants