Skip to content

Conversation

@mephesto1337
Copy link

It now uses declarativeNetRequestWithHostAccess which 'statically'
modifies requests with rules (useragent_tag_$COLOR.json) depending on
the theme currently loaded.
It also needs the management permission in order to determine which
profile/theme is currently being used.

As manifest v2 will stop working during 2023, it seems to me as a good time to upgrade.

It now uses `declarativeNetRequestWithHostAccess` which 'statically'
modifies requests with rules (useragent_tag_$COLOR.json) depending on
the theme currently loaded.
It also needs the `management` permission in order to determine which
profile/theme is currently being used.
As manifest v2 will not work during 2023, it seems to me as a good time
to upgrade.
If no `resourceTypes` is specified, then not all requests are matched.
@peter-h-ncc
Copy link
Contributor

Can you provide a link to details of manifest v2 being deprecated for documentation purposes? This looks like a change that I should merge sooner rather than later, any documentation is appreciated.

@mephesto1337
Copy link
Author

Hello, here is the link : https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/.
Its deprecation has been a bit postponed. It seems than in early 2024 (the date is still under review), extensions using the v2 manifest will stop working.

@mephesto1337
Copy link
Author

I should also note that I had to had a new custom header x-autochrome-tag. The new API does not allow modifying headers (only, add, delete and set). So I "set" the User-Agent with a fixed version of chrome and added the new header.
If a breaking change has to happened, both headers should be present for some time I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants