Skip to content

fix: Use new external class names (requires Moodle 4.2)#673

Open
hamzakhalem wants to merge 3 commits intoncstate-delta:mainfrom
hamzakhalem:patch-1
Open

fix: Use new external class names (requires Moodle 4.2)#673
hamzakhalem wants to merge 3 commits intoncstate-delta:mainfrom
hamzakhalem:patch-1

Conversation

@hamzakhalem
Copy link
Copy Markdown

No description provided.

@jrchamp
Copy link
Copy Markdown
Collaborator

jrchamp commented Aug 14, 2025

Hi @hamzakhalem! Thank you for your contribution. The classes were renamed and class aliases were added in Moodle 4.2.

https://github.com/moodle/moodle/blob/621c6e1048892929cb2f1180a3e8b46b053bf41d/public/lib/externallib.php#L37-L48

The class aliases are still present in Moodle 4.5, 5.0 and - at the moment - the main branch. At this time, we support Moodle 3.7 and newer, so merging this change would break support for Moodle 3.7 through Moodle 4.1. That is okay if - and only if - we are increasing our minimum supported version and increasing our version number to indicate backward incompatibility.

So, I will tag this as part of the mod_zoom "next major release" milestone for when it makes sense to drop support for older versions of Moodle.

@jrchamp jrchamp added the bc-break Breaks backward compatibility label Aug 14, 2025
@jrchamp jrchamp added this to the v6.0.0 milestone Aug 14, 2025
@jrchamp jrchamp changed the title fix: Update externallib.php to handle new classes in moodle 4.5 fix: Use new external class names (requires Moodle 4.2) Mar 23, 2026
jrchamp added 2 commits March 23, 2026 14:38
MOODLE_INTERNAL should only be checked when the file has side effects. The previous commit removed the only side effect: a require_once().
@jrchamp jrchamp mentioned this pull request Apr 21, 2026
@smbader
Copy link
Copy Markdown
Contributor

smbader commented Apr 23, 2026

This patch requires us to drop everything prior to 4.2. 4.1 was an LTS version and just ended roughly 6 months ago.
According to https://stats.moodle.org/ that looks to be about 1/3 of the current Moodle installs. We may need to wait a little longer on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bc-break Breaks backward compatibility

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants