fix: Use new external class names (requires Moodle 4.2)#673
fix: Use new external class names (requires Moodle 4.2)#673hamzakhalem wants to merge 3 commits intoncstate-delta:mainfrom
Conversation
|
Hi @hamzakhalem! Thank you for your contribution. The classes were renamed and class aliases were added in Moodle 4.2. The class aliases are still present in Moodle 4.5, 5.0 and - at the moment - the main branch. At this time, we support Moodle 3.7 and newer, so merging this change would break support for Moodle 3.7 through Moodle 4.1. That is okay if - and only if - we are increasing our minimum supported version and increasing our version number to indicate backward incompatibility. So, I will tag this as part of the mod_zoom "next major release" milestone for when it makes sense to drop support for older versions of Moodle. |
MOODLE_INTERNAL should only be checked when the file has side effects. The previous commit removed the only side effect: a require_once().
|
This patch requires us to drop everything prior to 4.2. 4.1 was an LTS version and just ended roughly 6 months ago. |
No description provided.