view: prioritize Moodle capabilities over assumed access of hosts#703
Merged
smbader merged 1 commit intoncstate-delta:fix/switch_rolesfrom Feb 26, 2026
Conversation
Contributor
|
I really love the cleanup and move to a capability controlled logic as it should be within Moodle. Making this change inadvertently fixes the role switch problem now that we treat the viewing role as configured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't know how to communicate my ideas clearly in #697. This pull request builds on that pull request, prioritizing Moodle capabilities over access assumptions for hosts and Zoom activity managers.
In summary:
viewjoinurlandviewdialin, it is wrong for us to override the Moodle administrator's choice of whether or not the user (based on their role) should have access to view that information. The Moodle administrator can decide whetherviewjoinurlandviewdialinare granted to roles that can edit Zoom activities or not and we should respect/reflect that choice.Net effect for complicated host variables:
$userishostis now only used to determine if the user is pre-registered$userisrealhostdoes not emit PHP Notice when role switched