-
Notifications
You must be signed in to change notification settings - Fork 66
Better error messages for accessing outside of trace context #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Did you run into limitations when you tried to decorate the functions in question? Is it because they're already decorated as properties? |
|
@MichaelRipa Can you also make this error message better in this PR? nnsight/src/nnsight/tracing/graph/node.py Line 143 in 149e14c
People have suggesting adding |
Done. I feel like there might be somewhere better upstream to catch and log this (since |
|
@JadenFiotto-Kaufman The node error message shows up in undesirable circumstances: Is this expected behavior (and if so would there be a better error to log) or a bug? |
Description
This PR introduces more informative error messages when trying to access
.input,.inputsor.outputoutside of a trace context.