fix: Regression on browser history due to replaceState proxy#34
Merged
ndungtse merged 3 commits intondungtse:testfrom Feb 27, 2025
Merged
fix: Regression on browser history due to replaceState proxy#34ndungtse merged 3 commits intondungtse:testfrom
ndungtse merged 3 commits intondungtse:testfrom
Conversation
fix: Disable loader on replace state and update ci versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made an error on: #32
By appliying same Proxy on pushState en replaceState this cause a regression and create issue on browser history
Because here the proxy is based on history.pushState also for replaceState. (
new Proxy(window.history.pushState, {)