Add more information to SimulationOutput #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusede
reviewed
May 15, 2025
| @@ -1,7 +1,7 @@ | |||
| pub mod accounts; | |||
| mod deadline; | |||
| pub mod engine; | |||
| mod error; | |||
| pub mod error; | |||
There was a problem hiding this comment.
error::* is already re-exported below
| @@ -112,9 +112,16 @@ pub enum ParseTokenIdError { | |||
|
|
|||
| #[near(serializers = [borsh, json])] | |||
| #[autoimpl(Deref using self.0)] | |||
| #[autoimpl(DerefMut using self.0)] | |||
There was a problem hiding this comment.
DerefMut was not implemented here on purpose: all mutations happen on Amounts level to enforce using .checked_...() operations
| #[derive(Debug, Clone, Default, PartialEq, Eq)] | ||
| pub struct Amounts<T = BTreeMap<TokenId, u128>>(T); | ||
|
|
||
| impl<T> From<T> for Amounts<T> { | ||
| fn from(m: T) -> Self { | ||
| Amounts(m) |
There was a problem hiding this comment.
Suggested change
| Amounts(m) | |
| Self::new(m) |
Comment on lines
+58
to
+60
| pub ft_withdrawals: Option<Vec<FtWithdraw>>, | ||
| pub nft_withdrawals: Option<Vec<NftWithdraw>>, | ||
| pub mt_withdrawals: Option<Vec<MtWithdraw>>, |
There was a problem hiding this comment.
Suggested change
| pub ft_withdrawals: Option<Vec<FtWithdraw>>, | |
| pub nft_withdrawals: Option<Vec<NftWithdraw>>, | |
| pub mt_withdrawals: Option<Vec<MtWithdraw>>, | |
| #[serde(skip_serializing_if = "Vec::is_empty")] | |
| pub ft_withdrawals: Vec<FtWithdraw>, | |
| #[serde(skip_serializing_if = "Vec::is_empty")] | |
| pub nft_withdrawals: Vec<NftWithdraw>, | |
| #[serde(skip_serializing_if = "Vec::is_empty")] | |
| pub mt_withdrawals: Vec<MtWithdraw>, |
| .unwrap(); | ||
| let sim_res = env.defuse.simulate_intents(signed.clone()).await.unwrap(); | ||
| assert_eq!(sim_res.balance_diff, into_simulation_diff(accounts.clone())); | ||
| println!("Balance diff: {:#?}", sim_res.balance_diff); |
There was a problem hiding this comment.
Maybe print the whole simulation output?
Suggested change
| println!("Balance diff: {:#?}", sim_res.balance_diff); | |
| println!("simulation_output: {}", serde_json::to_string(&sim_res).unwrap()); |
And do it before asserting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #74
This uses only the Inspector to get this data. This is why this is based on another branch as both have similar changes to the Inspector interface.