-
Notifications
You must be signed in to change notification settings - Fork 12
docs: testnet with tee support guide #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3391ad2 to
d772ef2
Compare
|
Fixing a private issue in a public PR feels a bit odd. It would be nice to have a dedicated public issue in this repo explaining that we have set up a cluster (we can still link to the private one about the setup), and that we should have a guide that helps anyone set up their own TEE testnet clusters. Not a hard blocker though. |
netrome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and comments, but nothing blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating a new file, we could reuse the existing docs/localnet/args/init.json template and just add an env var for the port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several differences between init.json and the nit_testnet_tee.json (different port ranges, IPs, and configurable account names).
I'm not saying it doesn't make sense to merge them together, but the overhead now (updating all localnet+localnet_TEE docs), is a but too much.
We can do this in a follow-up PR if really needed.
|
|
||
| ## Step 1: Create MPC Account | ||
|
|
||
| Since the faucet gives only **10 NEAR per account** (and the MPC contract storage costs **15 NEAR**), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you run the faucet multiple times for the same account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure there is no way to do this instead of the indirection? I'd advise to send a message to the SDK guys on telegram to ask for this. They are very responsive and helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @r-near
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using near-cli this is probably the simplest way to do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r-near I didn't understand your answer. is there a way to create an account with more than 10 near using faucet account? or fund it multiple time to achieve the same thing? if yes, can you provide the command (or link) ? I didn't find anything about this in documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure there is no way to do this instead of the indirection? I'd advise to send a message to the SDK guys on telegram to ask for this. They are very responsive and helpful.
do you mean this https://t.me/neardev ?
DSharifi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
2 changes that are blocking:
- I think you updated
libs/nearcoreby mistake - Don't hardcode
barak_tee_test1_as a prefix to the account names in your tests. I think we can reuse the approach for the currentdevnetREADME, where there are placeholders for the account name to use:
Lines 92 to 94 in a7c1489
First, create an MPC network. Pick a name; here I'll use "MPC_NETWORK_NAME=yourusername-test", but **ensure that your name is globally unique within the team**, so include your username in there.
deployment/testnet/sam.conf
Outdated
| MPC_ACCOUNT_ID=barak_tee_test1_sam.testnet | ||
| MPC_LOCAL_ADDRESS=127.0.0.1 | ||
| MPC_SECRET_STORE_KEY=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA | ||
| MPC_CONTRACT_ID=barak_tee_test1_mpc.testnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the guide should have a hard coded testnet name with your firstname in it. Can we make the name more generic like we have in the other guides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| ## Step 1: Create MPC Account | ||
|
|
||
| Since the faucet gives only **10 NEAR per account** (and the MPC contract storage costs **15 NEAR**), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure there is no way to do this instead of the indirection? I'd advise to send a message to the SDK guys on telegram to ask for this. They are very responsive and helpful.
sure: |
Co-authored-by: Daniel Sharifi <[email protected]>
Co-authored-by: Daniel Sharifi <[email protected]>
d772ef2 to
77693ad
Compare
fixed |
good idea |
fixes #1660
related https://github.com/near/mpc-private/issues/86 and https://github.com/near/mpc-private/pull/88