feat: add new signature scheme variant to contract #1658
+733
−807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindeforth
changed the title
kevindeforth
force-pushed
the
kd/1638-new-signature-scheme-variant-in-contract
branch
from
5aa351a to
71916ff
Compare
gilcu3
reviewed
Dec 15, 2025
| @@ -1,3 +1,4 @@ | |||
| // todo [#1657](https://github.com/near/mpc/issues/1657): split this file | |||
Contributor
There was a problem hiding this comment.
nit
Suggested change
| // todo [#1657](https://github.com/near/mpc/issues/1657): split this file | |
| // TODO(#1657): split this file |
as we are using it like that in some other places and IMO looks better
Comment on lines
+66
to
+73
| }; | ||
| pub const PARTICIPANT_LEN: usize = 10; | ||
| use utilities::AccountIdExtV1; | ||
|
|
||
| use crate::sandbox::initializing_utils::start_keygen_instance; | ||
|
|
||
| use super::initializing_utils::{vote_add_domains, vote_public_key}; | ||
|
|
Contributor
There was a problem hiding this comment.
it seems we are going back and forth between defining constants and use statements. Could you fix it by putting all constants below?
| @@ -1,5 +1,6 @@ | |||
| --- | |||
| source: crates/contract/tests/abi.rs | |||
| assertion_line: 48 | |||
Contributor
There was a problem hiding this comment.
this should not be added. It was also a problem in recent PR's by Simon, not sure why it does not happen to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1638
This PR ensures the new signature scheme variant is included in all tests, which leads to a slight refactor of the sandbox tests.
The tests are functionally the same, but the main difference is that before, we often only tested with a single domain (usually for Secp256k1), whereas now, we almost always test a contract that holds one domain for each signature scheme ([Secp256k1, Ed25519, Bls12381 V2Secp256k1])`.
Additionally, I took the opportunity to re-organize some helper functions and make them more robust. A natural follow-up is #1657.