perf: Use procedural macro to include expected measurements at compile time #1659
+423
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netrome
force-pushed
the
netrome/parse_tcb_info_at_compile_time
branch
from
585cba7 to
a5ca4e6
Compare
netrome
force-pushed
the
netrome/parse_tcb_info_at_compile_time
branch
2 times, most recently
from
5c395a1 to
191eb6d
Compare
netrome
commented
Dec 14, 2025
| derive_more::Deref, | ||
| )] | ||
| #[serde(transparent)] | ||
| pub struct HexBytes<const N: usize>(#[serde_as(as = "Hex")] [u8; N]); |
Collaborator
Author
There was a problem hiding this comment.
Note: I was surprised we didn't have this somewhere already. I think we could make use of this type in many more places if we break it out as a shared utility later.
netrome
force-pushed
the
netrome/parse_tcb_info_at_compile_time
branch
2 times, most recently
from
5e3c4e6 to
0e8604f
Compare
netrome
force-pushed
the
netrome/parse_tcb_info_at_compile_time
branch
from
0e8604f to
e2518aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1634
This is an alternative solution to the one proposed in #1646. Instead of relying on a custom build script to generate a rust module containing a hard-coded constant for the expected measurements, this PR introduces a procedural macro to generate the needed literals to statically instantiate the expected measurements. This allows us to load expected measurements at compile time simply by doing:
Side note: I noticed we didn't have a nice
TcbInfostruct to deserialize the JSON so a significant part of this PR is introducing that struct.