fix: align allowed_docker_image_hashes consumers with new return shape - #3761
Merged
kevindeforth merged 1 commit intoJul 9, 2026
Merged
Conversation
The view now returns [{ image_hash, expiry_timestamp_seconds }] instead of
bare hashes. Update the launcher localnet test scripts to select by
.image_hash (they compared array elements to a hash string, which never
matches an object), and fix the return type in the contract README and the
securing-mpc design doc.
|
PR title type suggestion: This PR changes only documentation and test scripts, so the type prefix should probably be Suggested title: |
Pull request overviewFollow-up to #3752 that reshaped Changes:
Reviewed changesPer-file summary
FindingsBlocking: none. Non-blocking:
✅ Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixups for #3752 to pull in — consumers of
allowed_docker_image_hashesthat the return-shape change misses (targets your branch so you can merge it into the PR).test-verify-and-upgrade.sh,test-hash-override.sh) parse the view withjq '.[] | select(. == $h)'— that compares each element to a hash string, which never matches now that elements are{ image_hash, expiry_timestamp_seconds }objects, so they'd fail even when the hash is approved. Switched toselect(.image_hash == $h).contract/README.mdandsecuring-mpc-with-tee-design-doc.mdstill showedVec<NodeImageHash>.Not touched (flagging, your call): softer prose mentions in operator/design docs (
running-an-mpc-node-in-tdx-external-guide.md,chain-gateway-design.mdreceiver type, the attestation-cli README "look in contract state" hint) — they reference the method but not its return shape directly. attestation-cli code itself is unaffected (takes hashes as CLI args).