feat: Add optional payload hash to foreign transaction requests - #4032

Merged

netrome merged 24 commits into

mainfrom

3997-audit-respond_verify_foreign_tx-doesnt-check-that-payload_hash-matches-the-response

Aug 7, 2026

Commits on Aug 7, 2026

feat: Add optional payload hash to foreign transaction requests
netrome
committed
5914722
chore: De-slopify
netrome
committed
242822f
refactor: Don't prefix with must for non-plumbing test helper + function order
netrome
committed
2b3fc6a
chore: Trim Given/When/Then comment annotations in sandbox tests
netrome
committed
08f3422
chore: De-slopify
netrome
committed
989aca7
refactor: Test heloper function order
netrome
committed
0219c4d
chore: More de-slopification
netrome
committed
eb63ddc
refactor: Propagate compute_msg_hash failure from request builder
netrome
committed
9a578f1
fix: Snapshot
netrome
committed
b981467
refactor: Derive expected payload hash in one place in the SDK

netrome
and
claude
committed
d9f9ee0
test: Assert the specific UnexpectedPayloadHash error in reject tests

netrome
and
claude
committed
0414dc6
test: Pin the omitted expected_payload_hash wire form in the catalog

netrome
and
claude
committed
a3f11e6
docs: Note that abandoned V2 pending entries leak their storage staking

netrome
and
claude
committed
e392196
test: Cover the SDK-bound expected_payload_hash path end to end

netrome
and
claude
committed
344c9d5
chore: Cargo.lock
netrome
committed
e5904bf
test: Assert the specific mismatch error in the node reject test

netrome
and
claude
committed
be65c73
refactor: Don't impose clones in `expected_payload_hash`
netrome
committed
bbf50d2
refactor: Reorder helpers
netrome
committed
e1cda01
refactor: Reuse `sign_foreign_tx_payload` helper
netrome
committed
370b554
chore: Explicit comment about previous loookup map
netrome
committed
07f7182
fix: Use asymmetric MOCK_BLOCK_HASH
netrome
committed
3da33dc
refactor: Omit confusing comment
netrome
committed
b93c31a
fix: Build signature request before presignature is popped from asset queue
netrome
committed
7af44d7
tests: Add test to ensure contract rejects request with erased expected payload hash
netrome
committed
63e84dd

Navigation Menu

Uh oh!

feat: Add optional payload hash to foreign transaction requests - #4032

feat: Add optional payload hash to foreign transaction requests#4032
netrome merged 24 commits into
mainfrom
3997-audit-respond_verify_foreign_tx-doesnt-check-that-payload_hash-matches-the-response

Commits on Aug 7, 2026

feat: Add optional payload hash to foreign transaction requests

chore: De-slopify

refactor: Don't prefix with must for non-plumbing test helper + function order

chore: Trim Given/When/Then comment annotations in sandbox tests

chore: De-slopify

refactor: Test heloper function order

chore: More de-slopification

refactor: Propagate compute_msg_hash failure from request builder

fix: Snapshot

refactor: Derive expected payload hash in one place in the SDK

test: Assert the specific UnexpectedPayloadHash error in reject tests

test: Pin the omitted expected_payload_hash wire form in the catalog

docs: Note that abandoned V2 pending entries leak their storage staking

test: Cover the SDK-bound expected_payload_hash path end to end

chore: Cargo.lock

test: Assert the specific mismatch error in the node reject test

refactor: Don't impose clones in `expected_payload_hash`

refactor: Reorder helpers

refactor: Reuse `sign_foreign_tx_payload` helper

chore: Explicit comment about previous loookup map

fix: Use asymmetric MOCK_BLOCK_HASH

refactor: Omit confusing comment

fix: Build signature request before presignature is popped from asset queue

tests: Add test to ensure contract rejects request with erased expected payload hash