test: Assert onchain timeout in recon test - #4051
Closed
SimonRastikian wants to merge 3 commits into
Closed
Conversation
Contributor
|
Suggested some changes in #4108 |
Contributor
|
@SimonRastikian could you take a look at this? |
Contributor
Author
|
Assigned to @kevindeforth #4215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a comment by Kevin over my 3164 PR.
TLDR Problem: The old test inferred the Cait-Sith timeout indirectly by racing it against a metric counter
Solution: The PR replaces the metric race in the distinct-reconstruction-thresholds test with a direct assertion on the sign request's on-chain timeout failure.