fix: Fixed cli command for memo parameter #446

FroVolod · 2025-02-08T09:24:25Z

This fixed the command:

near tokens volodymyr.testnet send-ft usdn.testnet fro_volod.testnet amount-ft '10 usn' prepaid-gas '100.0 Tgas' attached-deposit '1 yoctoNEAR' network-config testnet

to:

near tokens fro_volod.testnet send-ft usdn.testnet volodymyr.testnet '1 usn' memo Mem network-config testnet sign-with-legacy-keychain send

or

near tokens fro_volod.testnet send-ft usdn.testnet volodymyr.testnet '1 usn' memo '' --prepaid-gas '300.0 Tgas' --attached-deposit '1 yoctoNEAR' network-config testnet sign-with-legacy-keychain send

akorchyn

@race-of-sloths score 5

hey, few comments

akorchyn · 2025-02-11T10:30:16Z

src/commands/tokens/send_ft/amount_ft.rs

@@ -61,14 +57,6 @@ impl AmountFtContext {
            ft_contract_account_id: previous_context.ft_contract_account_id,
            receiver_account_id: previous_context.receiver_account_id,
            ft_transfer_amount,
-            memo: scope.memo.as_ref().and_then(|s| {


I would prefer this to be honest, over custom type that is not needed yet in the end.

akorchyn · 2025-02-11T10:31:06Z

src/types/optional_string.rs

@@ -0,0 +1,41 @@
+#[derive(Debug, Default, Clone)]


Do we really need this type? I think, it's a bit weird

race-of-sloths · 2025-02-11T10:32:42Z

@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Current status: executed

Reviewer	Score
@akorchyn	5

Your contribution is much appreciated with a final score of 5!
You have received 53 (50 base + 5% lifetime bonus) Sloth points for this contribution

@akorchyn received 25 Sloth Points for reviewing and scoring this pull request.

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths and receive a reward
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors
- Include a PR: @race-of-sloths include to enter the Race with your PR
For maintainers:
- Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
- Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
- Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
- Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

akorchyn · 2025-02-14T12:04:29Z

src/commands/tokens/send_ft/mod.rs

+    deposit: &crate::types::near_token::NearToken,
+    gas: &crate::common::NearGas,
+) -> color_eyre::eyre::Result<crate::commands::PrepopulatedTransaction> {
+    let mut transfer_args = serde_json::Map::new();


I think you can just
serde_json::json! {
receiver_id: receiver_account_id,
memo: memo.and(...)
amount: ...
}

Would be easier to read

src/commands/tokens/send_ft/amount_ft.rs

src/commands/tokens/send_ft/mod.rs

Co-authored-by: Vlad Frolov <[email protected]>

## 🤖 New release * `near-cli-rs`: 0.18.0 -> 0.19.0 (⚠ API breaking changes) ### ⚠ `near-cli-rs` breaking changes ```text --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/constructible_struct_adds_field.ron Failed in: field GlobalContext.verbosity in /tmp/.tmpqoEbVp/near-cli-rs/src/lib.rs:19 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_missing.ron Failed in: function near_cli_rs::common::create_used_account_list_from_keychain, previously in file /tmp/.tmpzjZyQv/near-cli-rs/src/common.rs:2604 --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_parameter_count_changed.ron Failed in: near_cli_rs::common::print_transaction_status now takes 3 parameters instead of 2, in /tmp/.tmpqoEbVp/near-cli-rs/src/common.rs:1323 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_pub_field_missing.ron Failed in: field teach_me of struct GlobalContext, previously in file /tmp/.tmpzjZyQv/near-cli-rs/src/lib.rs:19 ``` <details><summary>Changelog</summary> <blockquote> ## [0.19.0](v0.18.0...v0.19.0) - 2025-03-12 ### Added - Improved usability of NEAR CLI in scripts ([#445](#445)) - Added "send all" option to fungible tokens ([#440](#440)) - let users specify a memo when sending ft - A new `--quiet` flag to suppress noisy output in scripting scenarios ([#441](#441)) ### Fixed - Fixed information about successful transfer of "send all" ft tokens ([#447](#447)) - Fixed cli command for memo parameter ([#446](#446)) - Use legacy keychain as a fallback storage when system keychain is not supported (e.g. WSL, Codespaces, Docker containers, CI) ([#439](#439)) ### Other - [**breaking**] updates near-* dependencies to 0.29 release ([#455](#455)) - Typos fix ([#451](#451)) - Added the ability to add an account ID to the account list without using the legacy keychain ([#449](#449)) - Updated the copyright year to 2025 ([#448](#448)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).

start

a165d9d

FroVolod marked this pull request as ready for review February 10, 2025 08:33

FroVolod requested review from akorchyn, dj8yfo and PolyProgrammist as code owners February 10, 2025 08:33

akorchyn reviewed Feb 11, 2025

View reviewed changes

FroVolod added 3 commits February 11, 2025 18:05

refactored command

1cc959a

refactored

0c4569b

deleted preparat_ft_transfer

305119a

FroVolod marked this pull request as draft February 12, 2025 08:02

refactored

bcbe10c

FroVolod marked this pull request as ready for review February 12, 2025 09:23

akorchyn reviewed Feb 14, 2025

View reviewed changes

FroVolod and others added 2 commits February 14, 2025 21:06

refactored args_ft_transfer

43a6edb

Merge branch 'main' into update-for-memo-option

3859395

FroVolod marked this pull request as draft February 14, 2025 19:07

FroVolod marked this pull request as ready for review February 14, 2025 20:08

frol reviewed Feb 16, 2025

View reviewed changes

src/commands/tokens/send_ft/amount_ft.rs Outdated Show resolved Hide resolved

src/commands/tokens/send_ft/mod.rs Outdated Show resolved Hide resolved

src/commands/tokens/send_ft/mod.rs Outdated Show resolved Hide resolved

FroVolod and others added 3 commits February 16, 2025 10:20

Update src/commands/tokens/send_ft/mod.rs

f139a9e

Co-authored-by: Vlad Frolov <[email protected]>

Update src/commands/tokens/send_ft/mod.rs

2ca5b60

Co-authored-by: Vlad Frolov <[email protected]>

refactored

4073e24

frol approved these changes Feb 16, 2025

View reviewed changes

Merge branch 'main' into update-for-memo-option

a78105a

frol merged commit 76e0517 into main Feb 27, 2025
11 checks passed

frol deleted the update-for-memo-option branch February 27, 2025 23:19

github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevTools Feb 27, 2025

frol mentioned this pull request Feb 27, 2025

chore: release v0.19.0 #442

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Fixed cli command for memo parameter #446

fix: Fixed cli command for memo parameter #446

FroVolod commented Feb 8, 2025 •

edited

Loading

Uh oh!

akorchyn left a comment

Uh oh!

akorchyn Feb 11, 2025

Uh oh!

FroVolod Feb 11, 2025

Uh oh!

akorchyn Feb 11, 2025 •

edited

Loading

Uh oh!

FroVolod Feb 11, 2025

Uh oh!

race-of-sloths commented Feb 11, 2025 •

edited

Loading

Uh oh!

akorchyn Feb 14, 2025

Uh oh!

FroVolod Feb 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: Fixed cli command for memo parameter #446

fix: Fixed cli command for memo parameter #446

Conversation

FroVolod commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akorchyn left a comment

Choose a reason for hiding this comment

Uh oh!

akorchyn Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

FroVolod Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

akorchyn Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FroVolod Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

race-of-sloths commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akorchyn Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

FroVolod Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FroVolod commented Feb 8, 2025 •

edited

Loading

akorchyn Feb 11, 2025 •

edited

Loading

race-of-sloths commented Feb 11, 2025 •

edited

Loading