fix: Fixed information about successful transfer of "send all" ft tokens #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
Feb 14, 2025
Comment on lines
+106
to
+109
| pub fn update_amount(&mut self, new_amount: u128) -> Self { | ||
| self.amount = new_amount; | ||
| self.clone() | ||
| } |
There was a problem hiding this comment.
- This is a totally wrong implementation as it changes self and then clones and returns the copy
- This method is not needed. Just create a new
FungibleTokenwith::from_params_ft
| &ft_contract_account_id, | ||
| near_primitives::types::BlockId::Hash(outcome_view.receipts_outcome[0].block_hash).into() | ||
| ) { | ||
| let ft_transfer_amount = ft_balance.clone().update_amount(ft_transfer.amount); |
There was a problem hiding this comment.
^ use FungibleToken::from_params_ft instead
| network_config, | ||
| &signer_account_id, | ||
| &ft_contract_account_id, | ||
| near_primitives::types::BlockId::Hash(outcome_view.receipts_outcome[0].block_hash).into() |
There was a problem hiding this comment.
Take the block_hash from the last receipts_outcome, not the first one.
Suggested change
| near_primitives::types::BlockId::Hash(outcome_view.receipts_outcome[0].block_hash).into() | |
| near_primitives::types::BlockId::Hash(outcome_view.receipts_outcome.last().expect("FT transfer should have at least one receipt outcome, but none was received").block_hash).into() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes correct information about the successful transfer of ft tokens
Screen.Recording.2025-02-10.at.11.45.53.mov