feat: Display NFTs from contracts with null base_uri#2995
Open
cif wants to merge 2 commits intonear:masterfrom
Open
feat: Display NFTs from contracts with null base_uri#2995cif wants to merge 2 commits intonear:masterfrom
cif wants to merge 2 commits intonear:masterfrom
Conversation
👷 Deploy request for glittering-pavlova-0e9247 pending review.Visit the deploys page to approve it
|
👷 Deploy request for near-wallet-staging pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle tokens with null contract
base_uriThis PR changes the logic responsible for resolving NFT reference material for display in the collectibles tab.
Why the current implementation doesn't work
A JS template literal will render
nullinside of the string if the value is null rather than empty string. Even if the+concatenation operator is used instead,base_uri + '/' + referencewould cause clients to attempt to load from the current host.Motivation
While maintaining a shared
base_urlon the token contract can save storage and promote continuity between tokens, it is also advantageous allow a token to host its reference wherever it chooses.The NEP 177 specification provides for this, and should be handled if a token contract prefers to behave this way.