Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inline default implementation for more EpochManagerAdapter fns #12923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pugachAG
Copy link
Contributor

Moves code from EpochManager to be the default implementation for EpochManagerAdapter trait.
Similar to #12851.
This should also help avoiding issues like #12913.

@pugachAG pugachAG requested a review from a team as a code owner February 13, 2025 10:55
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 67.42424% with 43 lines in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (e8bbcfb) to head (8e1b0e2).

Files with missing lines Patch % Lines
chain/epoch-manager/src/adapter.rs 70.63% 7 Missing and 30 partials ⚠️
chain/chain/src/test_utils/kv_runtime.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12923      +/-   ##
==========================================
- Coverage   70.53%   70.51%   -0.03%     
==========================================
  Files         851      851              
  Lines      174921   174921              
  Branches   174921   174921              
==========================================
- Hits       123374   123338      -36     
- Misses      46420    46452      +32     
- Partials     5127     5131       +4     
Flag Coverage Δ
backward-compatibility 0.36% <0.00%> (ø)
db-migration 0.36% <0.00%> (ø)
genesis-check 1.42% <0.00%> (ø)
linux 70.37% <67.42%> (-0.02%) ⬇️
linux-nightly 70.15% <67.42%> (-0.02%) ⬇️
pytests 1.73% <0.00%> (ø)
sanity-checks 1.54% <0.00%> (ø)
unittests 70.34% <67.42%> (-0.03%) ⬇️
upgradability 0.36% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants