feat(synth-bm): allow multiple account prefixes #12935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooori
suggested changes
Feb 17, 2025
benchmarks/synth-bm/src/account.rs
Outdated
| /// - `a_user_<i>.<signer_account_id>,b_user_<i>.<signer_account_id>` | ||
| /// if `sub_account_prefixes == Some("a,b")` | ||
| #[arg(long, alias = "sub_account_prefix")] | ||
| pub sub_account_prefixes: Option<String>, |
There was a problem hiding this comment.
Storing prefixes in a Vec<String> would be more intuitive and requires just some minor tweaks.
Comment on lines
+120
to
+123
| Err(err) => { | ||
| let msg = format!("RPC call failed: {}", err); | ||
| warn_or_panic(&msg, self.response_check_severity); | ||
| } |
|
cc @Trisfald who is also working on using |
wacban
approved these changes
Feb 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12935 +/- ##
==========================================
+ Coverage 70.35% 70.48% +0.13%
==========================================
Files 854 854
Lines 175420 175591 +171
Branches 175420 175591 +171
==========================================
+ Hits 123412 123766 +354
+ Misses 46881 46681 -200
- Partials 5127 5144 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mooori
approved these changes
Feb 17, 2025
shreyan-gupta
pushed a commit
to shreyan-gupta/nearcore
that referenced
this pull request
Mar 28, 2025
During benchmarking I wanted to spawn txs between different shards, and for that it was convenient to use prefixes in the form `2,c,h,m,x`. Would it make sense in general? I retain `sub_account_prefix` as alias. Also I had an issue with RPC node crashing: `[2025-02-13T21:19:04Z WARN near_synth_bm::rpc] RPC call failed: error while sending payload: [error sending request for url (http://34.132.32.11:3030/)]` However, `response_check_severity` states that we can afford such errors, and it makes sense because they are very rare. So I suggest to use `warn_or_panic` for it as well.
shreyan-gupta
pushed a commit
to shreyan-gupta/nearcore
that referenced
this pull request
Mar 28, 2025
During benchmarking I wanted to spawn txs between different shards, and for that it was convenient to use prefixes in the form `2,c,h,m,x`. Would it make sense in general? I retain `sub_account_prefix` as alias. Also I had an issue with RPC node crashing: `[2025-02-13T21:19:04Z WARN near_synth_bm::rpc] RPC call failed: error while sending payload: [error sending request for url (http://34.132.32.11:3030/)]` However, `response_check_severity` states that we can afford such errors, and it makes sense because they are very rare. So I suggest to use `warn_or_panic` for it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During benchmarking I wanted to spawn txs between different shards, and for that it was convenient to use prefixes in the form
2,c,h,m,x. Would it make sense in general? I retainsub_account_prefixas alias.Also I had an issue with RPC node crashing:
[2025-02-13T21:19:04Z WARN near_synth_bm::rpc] RPC call failed: error while sending payload: [error sending request for url (http://34.132.32.11:3030/)]However,
response_check_severitystates that we can afford such errors, and it makes sense because they are very rare. So I suggest to usewarn_or_panicfor it as well.