-
Notifications
You must be signed in to change notification settings - Fork 754
Introduce GasKey to the trie. #13687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| &key.public_key, | ||
| ); | ||
| let storage_key = KeyForStateChanges::from_raw_key(block_hash, &data_key); | ||
| let changes_per_key_prefix = storage_key.find_iter(&store); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if that is relevant, but SingleAccessKeyChanges uses find_exact_iter, maybe that is what we should use here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye! But here we do not want to use find_exact_iter because the prefix includes changes to the gas key itself (i.e. balance changes) as well as any of the nonces under the gas key. This is different from the access key case where there's only one raw key.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13687 +/- ##
==========================================
- Coverage 69.41% 69.27% -0.15%
==========================================
Files 956 956
Lines 184142 184513 +371
Branches 184142 184513 +371
==========================================
- Hits 127830 127818 -12
- Misses 51252 51632 +380
- Partials 5060 5063 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
See near/NEPs#611 This PR adds the GasKey trie key. In subsequent PRs we will introduce a new transaction type to accept gas key transactions, and to implement the gas key actions.
See near/NEPs#611
This PR adds the GasKey trie key. In subsequent PRs we will introduce a new transaction type to accept gas key transactions, and to implement the gas key actions.