fix: prune stale hashes from orphan pool side-indexes on overflow cleanup#15629
Open
Trisfald wants to merge 2 commits intonear:masterfrom
Open
fix: prune stale hashes from orphan pool side-indexes on overflow cleanup#15629Trisfald wants to merge 2 commits intonear:masterfrom
Trisfald wants to merge 2 commits intonear:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15629 +/- ##
==========================================
+ Coverage 69.38% 69.43% +0.04%
==========================================
Files 942 938 -4
Lines 213590 213480 -110
Branches 213590 213480 -110
==========================================
+ Hits 148203 148223 +20
+ Misses 59490 59371 -119
+ Partials 5897 5886 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stedfn
reviewed
Apr 24, 2026
Contributor
There was a problem hiding this comment.
doesn't this have same issue?
Contributor
There was a problem hiding this comment.
if so we can also extract in separate function
stedfn
reviewed
Apr 24, 2026
| }); | ||
|
|
||
| self.height_idx.retain(|_, ref mut xs| xs.iter().any(|x| !removed_hashes.contains(x))); | ||
| self.prune_side_indexes(&removed_hashes); |
Contributor
There was a problem hiding this comment.
now this prunes orphans_requested_missing_chunks and prev_hash_idx, I do not see issues with that but mentioning
stedfn
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orphan pool overflow cleanup removed evicted blocks from
self.orphansbut left their hashes inprev_hash_idx/height_idxvectors whenever the bucket had at least one live sibling.Later parent recovery walked the stale entries and panicked on
unwrap().