chore: check write access#15645
Merged
andrei-near merged 4 commits intomasterfrom Apr 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “external contributor merge” Zulip notifier workflow to determine “external” status based on repository permission level (write/maintain/admin) rather than GitHub org membership signals, which can be hidden via private org membership.
Changes:
- Replace
author_association-based gating with a GitHub API permission check for the PR author. - Run the workflow on all merged PRs to
master, but only send the Zulip message when the author lacks write/maintain/admin. - Switch the Zulip API key secret reference to
ZULIP_GHA_API_KEY.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #15645 +/- ##
==========================================
+ Coverage 69.54% 69.56% +0.01%
==========================================
Files 940 940
Lines 214521 214521
Branches 214521 214521
==========================================
+ Hits 149198 149227 +29
+ Misses 59396 59379 -17
+ Partials 5927 5915 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shreyan-gupta
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking repo write access instead of org membership since user org membership data can be private and not visible via public api