test(state-sync): early kickout coverage for synced nodes#15983
Draft
stedfn wants to merge 3 commits into
Draft
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #15983 +/- ##
==========================================
+ Coverage 73.19% 73.27% +0.07%
==========================================
Files 856 857 +1
Lines 188394 188902 +508
Branches 188394 188902 +508
==========================================
+ Hits 137904 138417 +513
- Misses 46070 46071 +1
+ Partials 4420 4414 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Drop a roadmap clause from the module doc; keep the technical meaning (a red run is a real gap the tests guard against). Comments only, no code change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly-gated integration coverage that synced nodes do not stall under EarlyKickout.
EarlyKickout resolves chunk producers from a grandparent anchor backed by DBCol::ChunkProducers. A same-epoch anchor with a missing row returns ChunkProducerNotInDB and aborts chunk-signature / witness verification. These tests check that a node joining via the sync pipeline holds the rows its catch-up reads depend on.
Green proves syncs are safe because header and block processing seed the rows. The missing-row path is unreachable on master today: header sync seeds the contiguous range and DBCol::ChunkProducers is not garbage collected.