Skip to content

Conversation

@kobayurii
Copy link
Member

This pull request refactors how the transaction details storage provider is configured and accessed throughout the codebase. The main change is to move the tx_details_storage_provider field from specific sub-configs (like TxIndexerConfig and CommonGeneralTxIndexerConfig) to the top-level general configuration, ensuring consistent access and simplifying configuration management. The environment variable handling and default config files have also been updated to reflect this change.

Configuration refactoring:

  • Moved the tx_details_storage_provider field from CommonGeneralTxIndexerConfig and TxIndexerConfig to CommonGeneralConfig and GeneralRpcServerConfig, making it a top-level field in the general configuration. This change ensures a single source of truth for the storage provider setting. [1] [2] [3] [4]
  • Updated the deserialization logic for the tx_details_storage_provider field to use deserialize_data_or_env, allowing it to be set via environment variables more consistently.

Default configuration and environment variables:

  • Added tx_details_storage_provider to the default environment configuration file, documenting available options and the default value. Removed redundant or outdated configuration lines from sub-config sections. [1] [2]

Code usage updates:

  • Updated all references to tx_details_storage_provider in the codebase to use the new location in the general configuration, including in ServerContext and the tx-indexer main function. [1] [2]

Code cleanup:

  • Removed now-unnecessary fields and default logic for tx_details_storage_provider from sub-configs and constructors. [1] [2] [3] [4]

@kobayurii kobayurii requested a review from khorolets August 18, 2025 09:12
@kobayurii kobayurii self-assigned this Aug 18, 2025
@kobayurii kobayurii marked this pull request as ready for review August 18, 2025 09:12
@kobayurii kobayurii merged commit eb57f24 into develop Aug 18, 2025
3 checks passed
kobayurii added a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants