chore: remove concluded experiments and dead docker/sglang-glm5 - #144
Open
PierreLeGuen wants to merge 1 commit into
Open
PierreLeGuen wants to merge 1 commit into
PierreLeGuen wants to merge 1 commit into
Conversation
Delete 17 files with no long-term value beyond git history: - experiments/: the June INT4-AutoRound / compressed-tensors / NVFP4 quantization sweep (6 files, abandoned — prod graduated Qwen3.6 to FP8, gemma-4 to FP8-block, DSV4-Flash to FP4+EAGLE), the losing pack variants gemma4x2-qwen36x2 + qwen35-qwen36-gemma4 (dsv4-qwen36-gemma4 and qwen35-dsv4-flash won and are live), the otel_test harnesses (label contract landed fleet-wide in v0.0.252 + validators), gemma4-31b-qat-vllm (QAT path superseded by FP8-block in prod), and the graduated/losing GLM-5.1 AWQ configs (prod/GLM-5.1-SGL-AWQ-TP4.yaml is the live successor). - docker/sglang-glm5/: bake-weights-into-image experiment; build.sh has referenced a nonexistent Dockerfile.sglang-glm5 since day one, the nearaidev/sglang:glm5* images were rolled back in April and nothing references them since. Kept deliberately: experiments/GLM-5.1-FP8-TP8-archived.yaml (documented switch-back config while the AWQ quality evaluation is open) — now carries a STATUS header. Docs updated to match; local validation loops gain an existence guard so an empty experiments/ can't produce false INVALID lines.
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 17 files (-13.5K lines) that no longer add value beyond git history. Every deletion was verified against the live fleet (
/machines), prod configs, sibling repos (infra-docs / ansible / compose-manager), recent Slack, and open PRs before removal.Deleted
June quantization sweep (6 files) —
deepseek-v4-flash-int4-autoround-test,deepseek-v4-gemma4-int4-autoround-test,qwen36-gemma4-int4-autoround-test,qwen36-gemma4-int4-compressed-tensors-test,qwen36-gemma4-nvfp4-balanced,qwen36-nvfp4-x8-throughput. The sweep concluded: prod graduated Qwen3.6 to FP8+EAGLE, gemma-4 to FP8-block (prod comments cite ~1.9x over W4A16/QAT), DSV4-Flash to FP4-marlin TP2+EAGLE. None of their served-model-names/SNI domains exist in the live fleet; the ongoing DSV4 quantization campaign runs on tdx outside this repo.Losing pack variants (2) —
gemma4x2-qwen36x2,qwen35-qwen36-gemma4. The 06-01 three-way pack exploration was won byprod/dsv4-qwen36-gemma4.yaml(live on gpu07); the qwen35 co-location was resolved by the customer-drivenprod/qwen35-dsv4-flash.yaml(live on gpu30).OTel harnesses (2) —
otel_test,glm51_otel_test. The monitoring label contract they were built to develop landed fleet-wide in v0.0.252 and is enforced byscripts/validate_otel_labels.rb.Superseded GLM-5.1 configs (2) —
GLM-5.1-AWQ-4bit(graduated:prod/GLM-5.1-SGL-AWQ-TP4.yamlruns the same checkpoint/revision/topology plus EAGLE and the loader patch, live on 2 hosts) andGLM-5.1-AWQ-vllm(lost to SGLang; can't run EAGLE). Note: the 4bit file at HEAD registers to the prodglm-5-1domain despite its header claiming an isolated one — deploying it by accident would join the prod rotation without EAGLE. Deleting it removes a foot-gun.gemma4-31b-qat-vllm — QAT path superseded by FP8-block in prod; the 06-22 validator commit naming it was mechanical CI coverage, not active work.
docker/sglang-glm5/ (4 files) — bake-weights-into-image experiment.
build.shhas referenced a nonexistentDockerfile.sglang-glm5since its first commit (never runnable from a clean checkout); thenearaidev/sglang:glm5*images were rolled back from prod in April and nothing references them since.Deliberately kept
experiments/GLM-5.1-FP8-TP8-archived.yaml— README documents it as kept for reference, and it is the exact switch-back config for the open customer complaint (2026-07-15) about AWQ quality; infra-docs (inference.md, benchmarks/glm-5.1.md) reference it under its pre-rename name. It now carries a# STATUS: ARCHIVEDheader per the repo's own convention.cleanup-hf-model.yaml,test/isolation-*.yaml, all ofprod/,scripts/,.github/— documented utility, active fixtures, live configs, CI.VLLM_CACHE_ROOT=.../gemma4-31b-qat-vllmin two prod files is a cache-directory name on live hosts, not a file reference — left untouched to avoid invalidating warm caches.Docs
README/AGENT.md
experiments/descriptions updated; the local validation loops gain an[ -f "$f" ] || continueguard (CI already has one) so a sparseexperiments/can't print false INVALID lines.Notes for reviewers
codex/decouple-otel-from-datadog-labels) mechanically relabels every yaml, including 11 deleted here — it will hit trivial delete/modify conflicts on rebase; resolution is to drop its changes to the deleted files.experiments/files, so the directory stays in use.