Skip to content

fix(security): harden approval thread safety (TOCTOU + error handling) #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zmanian wants to merge 17 commits into from
Closed

fix(security): harden approval thread safety (TOCTOU + error handling) #1591

Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
da00fb8
fix(security): eliminate TOCTOU race in approval request_id check (#1…
zmanian Mar 23, 2026
12dd502
fix(agent): return errors when approval thread disappears (#1487)
zmanian Mar 23, 2026
755e962
test(agent): strengthen regression test for missing thread error hand…
zmanian Mar 23, 2026
d82d850
style: run cargo fmt
claude Mar 23, 2026
b8b7dd1
fix: convert remaining let-chains to nested ifs for MSRV compat
zmanian Mar 24, 2026
0832d65
style: fix cargo fmt line-length violation in process_approval
claude Mar 25, 2026
5235b96
fix(agent): eliminate TOCTOU in process_approval auto-approve + state…
claude Mar 30, 2026
4cb37c0
fix(agent): replace silent if-let-Some patterns with explicit match i…
claude Mar 31, 2026
93535c6
test(agent): strengthen auto-approve rollback tests to exercise produ…
zmanian Mar 31, 2026
3d8711f
fix(agent): check thread existence before auto-approve to eliminate T…
claude Apr 1, 2026
a05af08
fix(agent): merge approval take + auto-approve + state transition int…
claude Apr 1, 2026
11cf5d4
fix(agent): add missing source_channel args to thread_ops tests
zmanian Apr 1, 2026
cb1fa39
fix: correct block structure after cherry-pick conflict resolution
zmanian Apr 3, 2026
00263a4
Merge branch 'staging' into fix/approval-thread-safety
zmanian Apr 4, 2026
bc46a08
Merge branch 'staging' into fix/approval-thread-safety
zmanian Apr 6, 2026
a845d2c
fix(agent): consolidate rejection path into single lock scope
zmanian Apr 11, 2026
2a43b7f
fix(agent): gate AuthRequired SSE on thread existence, return bool fr…
zmanian Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading