fix(web): show active wasm channels correctly in settings#2375
Open
G7CNF wants to merge 8 commits intonearai:stagingfrom
Open
fix(web): show active wasm channels correctly in settings#2375G7CNF wants to merge 8 commits intonearai:stagingfrom
G7CNF wants to merge 8 commits intonearai:stagingfrom
Conversation
github-actions
bot
added
scope: channel/web
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a standalone MCP stdio bridge for the gws binary, featuring command allowlisting, secret redaction, and environment isolation. It also refactors extension activation logic to prioritize runtime state, ensuring WASM channels are treated as active regardless of owner-binding metadata, and updates the web UI accordingly. Feedback suggests cleaning up the internal API by removing now-unused parameters in activation functions and refactoring duplicated extension mapping logic between the server and extension handlers to improve maintainability.
G7CNF
force-pushed
the
codex/issue-2235-extension-activation-state
branch
from
dc3d504 to
58cee3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2235.\n\nCurrent runtime behavior for authenticated WASM channels is now reflected in the settings UI:\n- active + authenticated channels are shown as Active even if owner-bound metadata is not yet resolved\n- already-authenticated cards now show Reconfigure instead of Setup\n- pairing claim UI only appears when the channel is active but not owner-bound\n\nValidated with focused Rust tests and for the settings UI script.