Skip to content

chore(#750): migrate to tailwind 4 #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

confraria
Copy link

@confraria confraria commented Apr 4, 2025

closes #750

😅 I'm not very convinced with this solution as:

  • The ts files with colors are now duplicated with the global.css theme block
  • Not sure if the way to replace the plugin is the css import

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for quantum-deploy-previews ready!

Name Link
🔨 Latest commit 4fc3966
🔍 Latest deploy log https://app.netlify.com/sites/quantum-deploy-previews/deploys/67f02a3d54373a00087ed6fa
😎 Deploy Preview https://deploy-preview-753--quantum-deploy-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@confraria confraria closed this Apr 4, 2025
@confraria confraria reopened this Apr 4, 2025
@agubler
Copy link
Contributor

agubler commented Apr 7, 2025

@confraria I haven't tried this but could we keep a published plugin with users consuming it using the @plugin syntax? Is this something you tried during the upgrade?

@confraria
Copy link
Author

@confraria I haven't tried this but could we keep a published plugin with users consuming it using the @plugin syntax? Is this something you tried during the upgrade?

That was my first approach but after reading the plugin, the only thing that it was doing was adding the library files to scan.
So the @source seemed more appropriate.

I guess to keep publishing the plugin won't hurt. Maybe it can also support tailwind 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to tailwind 4
2 participants