Skip to content

Update example configs and add certificate validation#53

Open
dcmcand wants to merge 3 commits intomainfrom
update-example-configs
Open

Update example configs and add certificate validation#53
dcmcand wants to merge 3 commits intomainfrom
update-example-configs

Conversation

@dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Feb 5, 2026

Closes

Improves documentation and adds missing validation.

Description

  • Update all example configs to include git_repository section with placeholder values
  • Add certificate config to all examples showing selfsigned/letsencrypt options
  • Add CertificateConfig.Validate() to require acme.email when type: letsencrypt
  • Replace placeholder domain/repo URLs with generic examples
  • Use slices.Contains for cleaner validation code

How to Test

  1. Run tests: go test ./pkg/config/...
  2. Try parsing example configs: ./nic validate -f examples/aws-config.yaml
  3. Verify letsencrypt without email fails validation

Co-authored-by: Marcelo Villa <36754005+marcelovilla@users.noreply.github.com>
@dcmcand dcmcand requested a review from marcelovilla February 5, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants