Fix annotation access for Python 3.14 compatibility#33
Open
w0r1dhe110 wants to merge 1 commit intonebula-contrib:mainfrom
Open
Fix annotation access for Python 3.14 compatibility#33w0r1dhe110 wants to merge 1 commit intonebula-contrib:mainfrom
w0r1dhe110 wants to merge 1 commit intonebula-contrib:mainfrom
Conversation
Description:
Update annotation access to maintain compatibility with Python 3.14's deferred annotation evaluation (PEP 649 & PEP 749).
In Python 3.14, annotations are no longer eagerly evaluated and stored directly in __annotations__. Instead, they're deferred and accessed through special mechanisms. This change caused our previous direct dictionary access to fail with a KeyError.
The fix replaces direct __dict__["__annotations__"] access with getattr(..., "__annotations__", {}) which safely handles both:
Pre-3.14 versions where annotations are stored directly in __annotations__
Python 3.14+ where annotations use deferred evaluation
This ensures consistent behavior across Python versions while leveraging the new annotation system's benefits in 3.14+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update annotation access to maintain compatibility with Python 3.14's deferred annotation evaluation (PEP 649 & PEP 749).
In Python 3.14, annotations are no longer eagerly evaluated and stored directly in annotations. Instead, they're deferred and accessed through special mechanisms. This change caused our previous direct dictionary access to fail with a KeyError.
The fix replaces direct dict["annotations"] access with getattr(..., "annotations", {}) which safely handles both:
Pre-3.14 versions where annotations are stored directly in annotations Python 3.14+ where annotations use deferred evaluation This ensures consistent behavior across Python versions while leveraging the new annotation system's benefits in 3.14+.