Skip to content

replaced (Task.)project with getProject(); changed getByName() … #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replaced (Task.)project with getProject(); changed getByName() … #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ dependencies {
}
plugin 'commons-lang:commons-lang:2.6'

plugin ("org.eclipse.jgit:org.eclipse.jgit:$jgitVersion") {
plugin ("org.eclipse.jgit:org.eclipse.jgit:$jgitVersion") { //6.6.1.202309212850-r
transitive = false
}
plugin 'org.eclipse.jdt:core:3.1.1'
Expand Down Expand Up @@ -186,7 +186,7 @@ tasks.named('compileKotlin') {

['compileClasspath', 'runtimeClasspath', 'testCompileClasspath', 'testRuntimeClasspath'].each { confName ->
tasks.register("dependencyReport${confName.capitalize()}", DependencyReportTask) {
configurations = [project.configurations.getByName(confName)] as Set
configurations = [project.configurations.named(confName)] as Set
outputFile = new File(project.projectDir, "build/reports/project/${confName}-dependencies.txt")
}
check.dependsOn("dependencyReport${confName.capitalize()}")
Expand Down
10 changes: 6 additions & 4 deletions src/main/groovy/com/netflix/nebula/lint/plugin/LintGradleTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import com.netflix.nebula.lint.*
import org.gradle.api.DefaultTask
import org.gradle.api.GradleException
import org.gradle.api.Task
import org.gradle.api.file.ProjectLayout
import org.gradle.api.provider.ListProperty
import org.gradle.api.provider.Property
import org.gradle.api.tasks.Input
Expand All @@ -27,6 +28,8 @@ import org.gradle.api.tasks.Optional
import org.gradle.api.tasks.TaskAction
import org.gradle.internal.deprecation.DeprecationLogger

import javax.inject.Inject

import static com.netflix.nebula.lint.StyledTextService.Styling.*

abstract class LintGradleTask extends DefaultTask {
Expand Down Expand Up @@ -55,15 +58,14 @@ abstract class LintGradleTask extends DefaultTask {
} catch (NoSuchMethodException ignore) {
}
}

@TaskAction
void lint() {
//TODO: address Invocation of Task.project at execution time has been deprecated.
DeprecationLogger.whileDisabled {
def violations = new LintService().lint(project, onlyCriticalRules.get()).violations

def violations = new LintService().lint(getProject(), onlyCriticalRules.get()).violations
.unique { v1, v2 -> v1.is(v2) ? 0 : 1 }

(getListeners() + new GradleLintPatchAction(project) + new GradleLintInfoBrokerAction(project) + consoleOutputAction).each {
(getListeners() + new GradleLintPatchAction(getProject()) + new GradleLintInfoBrokerAction(getProject()) + consoleOutputAction).each {
it.lintFinished(violations)
}
}
Expand Down