Skip to content

Added a constants file for tree-shaking in ESBuild #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhayVAshokan merged 1 commit into from
Apr 8, 2025
Merged

Added a constants file for tree-shaking in ESBuild #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import packageJson from "./package.json";

const commonResolve = require("@bigbinary/neeto-commons-frontend/configs/nanos/webpack/resolve.js");
const projectResolve = require("./resolves.js");
const postCssPlugin = require("./rollup-config/postcss.config.js")
const postCssPlugin = require("./rollup-config/postcss.config.js");

const { alias: aliasEntries } = mergeDeepLeft(projectResolve, commonResolve);
const peerDependencies = Object.keys(packageJson.peerDependencies);
Expand All @@ -33,7 +33,8 @@ const input = {
FormikEditor: "./src/components/Editor/FormikEditor",
Attachments: "./src/components/Attachments",
utils: "./src/utils",
}
constants: "./src/constants",
};

const plugins = [
peerDepsExternal(),
Expand Down Expand Up @@ -66,8 +67,12 @@ const config = args => {
const output = formats.map(format => ({
assetFileNames: "[name][extname]",
dir: path.join(destination),
entryFileNames: format === "esm" ? "dist/[name].js" : "dist/cjs/[name].cjs.js",
chunkFileNames: format === "esm" ? "dist/chunk-[hash].js" : "dist/cjs/chunk-[hash].cjs.js",
entryFileNames:
format === "esm" ? "dist/[name].js" : "dist/cjs/[name].cjs.js",
chunkFileNames:
format === "esm"
? "dist/chunk-[hash].js"
: "dist/cjs/chunk-[hash].cjs.js",
format,
name: "NeetoEditor",
sourcemap: true,
Expand All @@ -82,7 +87,8 @@ const config = args => {
plugins: [
cleaner({ targets: ["./dist/"] }),
...plugins,
args.app && copy({
args.app &&
copy({
targets: [
{ src: "package.json", dest: destination },
{ src: "types.d.ts", dest: destination },
Expand Down Expand Up @@ -159,7 +165,7 @@ const config = args => {
assetFileNames: "[name][extname]",
},
},
]
}
];
};

export default config;
5 changes: 5 additions & 0 deletions src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { EDITOR_OPTIONS } from "common/constants";

import { DEFAULT_EDITOR_OPTIONS } from "components/Editor/constants";

export { EDITOR_OPTIONS, DEFAULT_EDITOR_OPTIONS };
Loading