Skip to content

Added close button and outside click functionality to exit from upload image/video modal #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

Added close button and outside click functionality to exit from upload image/video modal #1371

merged 2 commits into from
Apr 29, 2025

Conversation

SumitPanda0
Copy link
Contributor

@SumitPanda0 SumitPanda0 commented Apr 29, 2025 •
edited
Loading

Description

  • Added a close button in the image upload modal and video upload modal. Additionally, improved the alignment of the image modal TABS with the close button.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@SumitPanda0 SumitPanda0 marked this pull request as ready for review April 29, 2025 06:21
@SumitPanda0
Copy link
Contributor Author

@AbhayVAshokan _a
Please review this PR.

@AbhayVAshokan
Copy link
Contributor

Next time, while creating a new PR in a Nano, please add one of the following labels (patch, minor, or major). This label is necessary to release a new version after a merge. The required label can be added according to Semantic Versioning.

Since this is a small non-breaking change, I'll add the patch _t label.

@neetogit-bot neetogit-bot bot added the patch Releases small requests or bug fixes. label Apr 29, 2025
@AbhayVAshokan AbhayVAshokan merged commit 77153c8 into main Apr 29, 2025
@AbhayVAshokan AbhayVAshokan deleted the 1367-cannot-exit-from-upload-imagevideo-modal branch April 29, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AbhayVAshokan AbhayVAshokan

Labels

patch Releases small requests or bug fixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot exit from upload image/video modal

2 participants

@SumitPanda0 @AbhayVAshokan