Fixed packge.json#699
Merged
Merged
Conversation
…endencies - Migrate 21 function components from deprecated defaultProps to JS default parameters (React 18.3+ deprecation) - Remove unused dependencies: @react-native-community/hooks, react-native-web, react-native-fast-image - Move build-only deps to devDependencies: @babel/plugin-proposal- export-namespace-from, patch-package, react-native-gesture-handler, @bigbinary/neeto-commons-frontend (needed by eslint plugin) - Remove AnimatedImage component and its storybook story - Fix peerDependencies to use >= ranges instead of exact versions
…entry - Remove react-native-safe-area-context from dependencies (keep in peerDependencies only) to avoid version conflicts with consuming apps - Update main entry to ./src/index.js - Remove leftover react-native-fast-image patch file
There was a problem hiding this comment.
🤖 NeetoBugWatch Review
I've analyzed your pull request and found some potential improvements that might be worth considering. Please review the specific line comments below for helpful suggestions.
💡 To trigger a re-review of this PR, add a comment with neeto-bugwatch-run on its own line (not inside a code block or blockquote).
Warning
Verdict: Needs review — 6 comments found, including major issues
Click to copy prompt for AI agent
Verdict: review_required
The following are code review comments from an AI reviewer that only has access
to the PR diff, not the full codebase. Treat every comment as a hypothesis,
not a fact. For each comment:
1. Investigate the verification questions against the full codebase first.
2. Go beyond the provided questions. Use your full codebase access to ask your
own questions, check related code paths, and consider edge cases that the
reviewer could not have seen from the diff alone.
3. Only implement the suggested fix if your investigation confirms the issue is real.
4. If the issue is not real, skip it entirely. Do not implement speculative fixes.
Prioritize by severity (critical > major > minor > trivial) and confidence score.
Only attend to comments with confidence below 0.5 if your investigation proves them valid.
[
{
"file_path": "package.json",
"line_number": 73,
"comment": "The 'react-native-gesture-handler' package was removed from 'dependencies' and moved to 'devDependencies'. For a React Native library that likely uses this package at runtime (e.g., in BottomSheet or Swipeable components), this will cause runtime 'Module not found' errors for consumers.",
"confidence": 0.95,
"severity": "major",
"suggested_fix": "Move 'react-native-gesture-handler' to 'peerDependencies' to ensure consumers install a compatible version, while keeping it in 'devDependencies' for development.",
"verification_questions": [
"Is 'react-native-gesture-handler' actually used in the runtime code of any component?",
"Is it expected that consumers of neetoui-rn provide their own version of gesture handler?"
]
},
{
"file_path": "src/components/MultiSelect.jsx",
"line_number": 195,
"comment": "The 'selectedValue' prop is defaulted to an empty function '() => {}'. Usually, 'selectedValue' (or similar naming) represents the state/data (like an array of IDs), while a function would be an 'onSelect' or 'onChange' callback. If the component logic expects an array, a function default will cause runtime errors.",
"confidence": 0.85,
"severity": "major",
"suggested_fix": "Determine if 'selectedValue' is a value or a callback. If it is the selected data, default it to '[]' or 'null'. If it is a callback, consider renaming it to 'onValueChange' or similar for clarity.",
"verification_questions": [
"Is 'selectedValue' used as a callback function or as the data representation of what is currently selected?",
"Does the component code call 'selectedValue()' or does it treat it as an iterable?"
]
},
{
"file_path": "src/components/BottomSheet.jsx",
"line_number": 173,
"comment": "Setting the default 'labelExtractor' to an empty function '() => {}' results in 'undefined' being returned for every item. This will lead to empty text being rendered for all items in the BottomSheet list.",
"confidence": 1.0,
"severity": "minor",
"suggested_fix": "Provide a more sensible default like 'item => item?.label' or ensure the component handles undefined labels gracefully.",
"verification_questions": [
"Does the component have a fallback when the extractor returns undefined?",
"Was the intention to force users to always provide their own extractor?"
]
},
{
"file_path": "package.json",
"line_number": 4,
"comment": "Changing the 'main' entry point from the root to './src/index.js' is a breaking change. If users were previously importing modules via sub-paths or if the build system expects the root to be the entry, this could break existing integrations.",
"confidence": 0.9,
"severity": "minor",
"suggested_fix": "Verify that all consumers of this library are updated to handle the new entry point and that automated build/release pipelines are aware of this change.",
"verification_questions": [
"Do any internal apps import from this library using sub-paths that might be affected?",
"Is the library intended to be used in environments where a specific entry point is required for tree-shaking?"
]
},
{
"file_path": "src/components/Container.jsx",
"line_number": 17,
"comment": "The default 'color' prop is set to 'background.primary'. In 'styled-system', 'color' typically refers to the foreground (text) color. Setting this on a Container might inadvertently change the default text color for all child components to a background color variable.",
"confidence": 0.8,
"severity": "minor",
"suggested_fix": "Check if 'bg' or 'backgroundColor' was the intended prop for 'background.primary'. If text color was intended, verify that 'background.primary' is a valid color in the font/text theme palette.",
"verification_questions": [
"Is 'color' intended to be the background color for the View component?",
"Does the styled 'View' component map the 'color' prop specifically to a style property other than text color?"
]
},
{
"file_path": "src/components/Typography.jsx",
"line_number": 91,
"comment": "The default value for 'textStyle' is set to the string 'defaultTextStyle'. If this key is missing from the theme definition for text styles, the component might fail to apply any styles or use inconsistent fallbacks.",
"confidence": 0.7,
"severity": "trivial",
"suggested_fix": "Ensure that 'defaultTextStyle' is a valid and consistently defined key in the project's theme configuration.",
"verification_questions": [
"Is 'defaultTextStyle' defined in the styled-system theme for Typography?",
"What is the behavior of the component if the provided textStyle string is not found in the theme?"
]
}
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.