Skip to content

Added extraLarge size prop to the Pane#2466

Merged
josephmathew900 merged 2 commits into
mainfrom
2454-support-extra-large-size-prop-in-pane
Apr 7, 2025
Merged

Added extraLarge size prop to the Pane#2466
josephmathew900 merged 2 commits into
mainfrom
2454-support-extra-large-size-prop-in-pane

Conversation

@thomas-mathai
Copy link
Copy Markdown
Contributor

@thomas-mathai thomas-mathai commented Apr 4, 2025

Description

  • Added size extraLarge prop to Pane component.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@thomas-mathai thomas-mathai added the patch Releases small requests or bug fixes. label Apr 4, 2025
@thomas-mathai thomas-mathai marked this pull request as ready for review April 4, 2025 14:46
@thomas-mathai
Copy link
Copy Markdown
Contributor Author

NeetoUI
image

NeetoCal - Tested the extraLarge prop using yalc
image

@praveen-murali-ind _a Can you please check?

@neetodeploy neetodeploy Bot had a problem deploying to neeto-ui-agsb-pr-2466 April 4, 2025 15:43 Failure
Copy link
Copy Markdown
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephmathew900 _a Please review.

Copy link
Copy Markdown
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit fd6cce5 into main Apr 7, 2025
1 check passed
@josephmathew900 josephmathew900 deleted the 2454-support-extra-large-size-prop-in-pane branch April 7, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Releases small requests or bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support extraLarge size prop for Pane component

3 participants