Skip to content

Add tooltip support to custom select options in Select component#2505

Merged
VedanshAgrawal22 merged 7 commits into
mainfrom
2504-add-support-to-show-tooltip-in-select-options
Jun 23, 2025
Merged

Add tooltip support to custom select options in Select component#2505
VedanshAgrawal22 merged 7 commits into
mainfrom
2504-add-support-to-show-tooltip-in-select-options

Conversation

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor

@VedanshAgrawal22 VedanshAgrawal22 commented Jun 20, 2025

Description
Adds support to display a tooltip over the options in Select dropdown.

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.
- [ ] I have added proper data-cy and data-testid attributes.

  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@VedanshAgrawal22 VedanshAgrawal22 self-assigned this Jun 20, 2025
@VedanshAgrawal22 VedanshAgrawal22 added the patch Releases small requests or bug fixes. label Jun 20, 2025
@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2505 June 20, 2025 05:40 Inactive
@neetodeploy neetodeploy Bot had a problem deploying to neeto-ui-agsb-pr-2505 June 20, 2025 05:42 Failure
@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

Closing and reopening the PR to trigger redeployment.

@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2505 June 20, 2025 05:46 Inactive
@VedanshAgrawal22 VedanshAgrawal22 marked this pull request as ready for review June 20, 2025 05:58
@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

@josephmathew900 _a Could you please review this?

Copy link
Copy Markdown
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2505 June 23, 2025 05:12 Inactive
@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2505 June 23, 2025 05:25 Inactive
@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

Closing and reopening the PR to trigger redeployment.

@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2505 June 23, 2025 06:00 Inactive
@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

@josephmathew900 _a Addressed the review comments.

Copy link
Copy Markdown
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/components/Select.jsx Outdated
Comment thread stories/Components/Select.stories.jsx Outdated
@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2505 June 23, 2025 13:00 Inactive
@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

@josephmathew900 _a Made the changes.

Copy link
Copy Markdown
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VedanshAgrawal22 _a Make the change and merge the PR.

Comment thread src/components/Select.jsx Outdated
@VedanshAgrawal22 VedanshAgrawal22 merged commit f1afaf4 into main Jun 23, 2025
1 check passed
@VedanshAgrawal22 VedanshAgrawal22 deleted the 2504-add-support-to-show-tooltip-in-select-options branch June 23, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Releases small requests or bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to show Tooltip in Select options

2 participants